ShellClients: Use translation y instead of clone and use gesturetransition for animation #2192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenemter
reviewed
Dec 24, 2024
lenemter
reviewed
Dec 24, 2024
leolost2605
force-pushed
the
leolost/panel-translation-y
branch
3 times, most recently
from
9d6076b to
d1b7e6f
Compare
Member
Author
|
@lenemter ok I've removed the gesturetracker passing from this commit so that it will make more sense in the commit history where we'll introduce it once we actually need it :) |
leolost2605
force-pushed
the
leolost/panel-translation-y
branch
from
d1b7e6f to
b1668ed
Compare
lenemter
reviewed
Jan 5, 2025
leolost2605
force-pushed
the
leolost/panel-translation-y
branch
from
b1668ed to
be663d6
Compare
leolost2605
changed the title
Member
Author
leolost2605
force-pushed
the
leolost/panel-translation-y
branch
from
be663d6 to
10e2c97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #2150 for easier review.
This introduces some inconsistencies when opening multitasking view and switching workspaces but these will be fixed properly by the follow ups from #2150.
The changes here include using the translation-y property of the window actor to hide it instead of making it invisible and animating a clone. Also included is the use of the GesturePropertyTransition for the actual animation and the related introduction of GestureTrackers. This is preparation for moving all panel hiding stuff to the shell clients (instead of the multitasking view doing its own thing with additional clones) as well as one to one touch gestures for showing the dock.